Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support archive logs in resource template. Fixes:#9900 #13933

Merged
merged 11 commits into from
Dec 30, 2024
Merged

feat: support archive logs in resource template. Fixes:#9900 #13933

merged 11 commits into from
Dec 30, 2024

Conversation

shuangkun
Copy link
Member

@shuangkun shuangkun commented Nov 24, 2024 •
edited
Loading

Archive logs in resource template helps to better observe the life cycle status of the resource.

wait container log

time="2024-12-15T09:03:13.109Z" level=info msg="S3 Save path: /tmp/argo/outputs/logs/main.log, key: resource-tmpl-wf/resource-tmpl-wf-wf1-2914235474/main.log"
time="2024-12-15T09:03:13.110Z" level=info msg="Creating minio client using static credentials" endpoint="minio:9000"
time="2024-12-15T09:03:13.110Z" level=info msg="Saving file to s3" bucket=my-bucket endpoint="minio:9000" key=resource-tmpl-wf/resource-tmpl-wf-wf1-2914235474/main.log path=/tmp/argo/outputs/logs/main.log
time="2024-12-15T09:03:13.130Z" level=info msg="Save artifact" artifactName=main-logs duration=20.227167ms error="<nil>" key=resource-tmpl-wf/resource-tmpl-wf-wf1-2914235474/main.log
time="2024-12-15T09:03:13.130Z" level=info msg="not deleting local artifact" localArtPath=/tmp/argo/outputs/logs/main.log
time="2024-12-15T09:03:13.130Z" level=info msg="Successfully saved file: /tmp/argo/outputs/logs/main.log"

Fixes #9900

Motivation

Modifications

Verification

@shuangkun shuangkun marked this pull request as draft November 24, 2024 13:30
@shuangkun shuangkun marked this pull request as ready for review December 16, 2024 07:24
@shuangkun
feat: support archive logs in resource template. Fixes:argoproj#9900
ad20250 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: output.
beba192 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: test.
c589acf 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: wait.
f1eac99 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: add e2e test.
ff2b846 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: change workflow name.
d7d9458 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: change status.phase.
e76b2e0 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: log.
c0e9c47 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: test fail.
c41098f 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: test.
99f312f 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
fix: move artifacts generate to ReportOutputsLogs.
75b6330 
Signed-off-by: shuangkun <[email protected]>
@shuangkun
Copy link
Member Author

/retest

@shuangkun shuangkun closed this Dec 19, 2024
@shuangkun shuangkun reopened this Dec 19, 2024
@tczhao tczhao merged commit 2e0f2f7 into argoproj:main Dec 30, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

Assignees
No one assigned
Labels
area/archive-logs Archive Logs feature area/templates/resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource template logs for spark application don't get archived in artifact repo
2 participants
@shuangkun @tczhao